Re: [PATCH 1/5] ASoC: dapm: If one widget fails, do not force allsubsequent widgets to fail too

From: Mark Brown
Date: Tue Jul 31 2012 - 11:15:58 EST


On Tue, Jul 31, 2012 at 04:09:08PM +0100, Lee Jones wrote:
> On 31/07/12 15:56, Mark Brown wrote:

> >To reiterate, this is in *no* way urgent or even a bug fix.

> It fixes sound in our driver.

> Without this the card failes to instantiate.

You're kidding, right? Fix the actual error.

> Isn't the return code incorrect? There are a multitude of reasons
> why snd_soc_dapm_new_control() would fail. No-memory is just one of
> them, so why do we force this probable lie?

I don't think anyone actually cares what the error code is, feel free to
pick another random number.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/