Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for DeviceTree

From: Mark Brown
Date: Mon Jul 30 2012 - 09:39:25 EST


On Mon, Jul 30, 2012 at 07:53:36AM +0100, Lee Jones wrote:
> On 29/07/12 21:42, Mark Brown wrote:

> >>+ if (of_get_property(np, "stericsson,use-pinctrl", NULL))

> >This doesn't seem particularly sane... why is this conditional?

> It's conditional because only MSP1 and MSP3 have pinctrl support.

Why does the driver care - doesn't the pinctrl abstraction and/or
bindings handle this sensibly?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/