Re: [PATCH] Add Etron XHCI quirk to avoid warning spam

[Daniel J Blueman]

On 28 July 2012 01:10, Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> wrote:
> On Fri, Jul 27, 2012 at 02:40:56PM +0800, Daniel J Blueman wrote:
>> On 27 July 2012 14:14, Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> wrote:
>> > On Fri, Jul 27, 2012 at 12:03:44PM +0800, Daniel J Blueman wrote:
>> >> When various USB3 devices with Etron XHCI controllers, we see a bunch of
>> >> warnings:
>> >> xhci_hcd 0000:02:00.0: WARN Successful completion on short TX: needs
>> >> XHCI_TRUST_TX_LENGTH quirk?
>> >>
>> >> Acknowledge the issue by adding the quirk.
>> >>
>> >> Signed-off-by: Daniel J Blueman <daniel@xxxxxxxxx>
>> []
>> > I already have a patch in my queue for this.  However, it keys off the
>> > PCI_DEVICE_ID_ASROCK_P67 PCI device ID.  Do you have another Etron
>> > device with a different device ID that needs this quirk?
>>
>> Yes, the subsystem ID is different [1] (but Zotac program it the same
>> as the vendor and device IDs here), however what you say suggests the
>> problem is general to this Etron XHCI controller (1b6f:7023), as we'd
>> suspect anyway.
>>
>> Thus the more general patch I posted makes better sense perhaps?
>
> I'd really like to keep this quirk specific to the particular PCI vendor
> and device ID.  It's possible that their next chip version will have the
> opposite issue (short TX completion code and bad untransferred length).
>
> Your patch turned it on for all Etron hosts, so I would rather keep my
> version:
>
> http://git.kernel.org/?p=linux/kernel/git/sarah/xhci.git;a=commit;h=12751f75720391bb2b607acdb2537f02e313251e
[]

Ok, the patch is correct since PCI_DEVICE_ID_ASROCK_P67 evaluates to
0x7023, which is the Etron EJ168 device ID.

Board-specific IDs (as the definition name suggests) are used for the
subsystem IDs, so this name is misleading (and misled me at least).

Can you fix this up with a patch to change PCI_DEVICE_ID_ASROCK_P67 to
PCI_DEVICE_ID_ETRON_EJ168, else I can cook and test a patch?

Thanks,
  Daniel
-- 
Daniel J Blueman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/