RE: [PATCH 2/2] lp8727_charger: unregister power supply at errorpath of lp8727_register_psy

From: Pallala, Ramakrishna
Date: Mon Jul 30 2012 - 00:48:20 EST


> if (power_supply_register(pchg->dev, &psy->usb))
> - goto err_psy;
> + goto err_psy_ac;

"err_psy_ac" label name is confusing. Why can't you use err_psy_usb

> if (power_supply_register(pchg->dev, &psy->batt))
> - goto err_psy;
> + goto err_psy_usb;

Same here, why don't you use err_psy_batt

Thanks,
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/