Re: [PATCH] gpio-sch: Fix leak of resource

From: Linus Walleij
Date: Sun Jul 29 2012 - 11:52:15 EST


On Tue, Jul 24, 2012 at 2:55 PM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> From: Alan Cox <alan@xxxxxxxxxxxxxxx>
>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> ---
>
> drivers/gpio/gpio-sch.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
> index 424dce8..8707d45 100644
> --- a/drivers/gpio/gpio-sch.c
> +++ b/drivers/gpio/gpio-sch.c
> @@ -241,7 +241,8 @@ static int __devinit sch_gpio_probe(struct platform_device *pdev)
> break;
>
> default:
> - return -ENODEV;
> + err = -ENODEV;
> + goto err_sch_gpio_core;
> }
>
> sch_gpio_core.dev = &pdev->dev;

Applied to my fixes branch, CCing the list if there are complaints.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/