Re: [PATCH] Add Etron XHCI quirk to avoid warning spam

[Daniel J Blueman]

On 27 July 2012 14:14, Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> wrote:
> On Fri, Jul 27, 2012 at 12:03:44PM +0800, Daniel J Blueman wrote:
>> When various USB3 devices with Etron XHCI controllers, we see a bunch of
>> warnings:
>> xhci_hcd 0000:02:00.0: WARN Successful completion on short TX: needs
>> XHCI_TRUST_TX_LENGTH quirk?
>>
>> Acknowledge the issue by adding the quirk.
>>
>> Signed-off-by: Daniel J Blueman <daniel@xxxxxxxxx>
[]
> I already have a patch in my queue for this.  However, it keys off the
> PCI_DEVICE_ID_ASROCK_P67 PCI device ID.  Do you have another Etron
> device with a different device ID that needs this quirk?

Yes, the subsystem ID is different [1] (but Zotac program it the same
as the vendor and device IDs here), however what you say suggests the
problem is general to this Etron XHCI controller (1b6f:7023), as we'd
suspect anyway.

Thus the more general patch I posted makes better sense perhaps?

Thanks,
  Daniel

--- [1]

# lspci -vs 02:00.0
02:00.0 USB controller: Etron Technology, Inc. EJ168 USB 3.0 Host
Controller (rev 01) (prog-if 30 [XHCI])
	Subsystem: Etron Technology, Inc. EJ168 USB 3.0 Host Controller
[]
# lspci -vns 02:00.0
02:00.0 0c03: 1b6f:7023 (rev 01) (prog-if 30 [XHCI])
	Subsystem: 1b6f:7023
-- 
Daniel J Blueman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/