Re: [PATCH] cpuidle: coupled: fix sleeping while atomic in cpu notifier

From: Rafael J. Wysocki
Date: Thu Jul 26 2012 - 16:10:51 EST


On Thursday, July 26, 2012, Rafael J. Wysocki wrote:
> On Thursday, July 26, 2012, Colin Cross wrote:
> > On Thu, Jul 26, 2012 at 12:55 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> > > On Wednesday, July 25, 2012, Colin Cross wrote:
> > >> The cpu hotplug notifier gets called in both atomic and non-atomic
> > >> contexts, it is not always safe to lock a mutex. Filter out all events
> > >> except the six necessary ones, which are all sleepable, before taking
> > >> the mutex.
> > >
> > > I wonder what mutual exclusion mechanis we rely on when the mutex is not taken?
> >
> > We don't need any mutual exclusion because the notifier returns immediately.
>
> Don't we need to disable preemption even?

Sorry, scratch that. It returns NOTIFY_OK if we're not going to take the
mutex.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/