Re: [PATCH 17/21] ASoC: Ux500: Enable ux500 PCM driver for DeviceTree

From: Mark Brown
Date: Thu Jul 26 2012 - 10:22:29 EST


On Thu, Jul 26, 2012 at 02:52:09PM +0100, Lee Jones wrote:
> On 26/07/12 12:38, Mark Brown wrote:

> >>- pr_info("%s: Register platform-device 'ux500-pcm'\n", __func__);
> >>- platform_device_register(&ux500_pcm);

> >This has the same issue as your last patch... the way you're doing
> >things will break audio on all boards using this driver.

> It will, why?

You've just removed registration of the device and not added anything
else to replace that. Even if all boards convert to DT their DTs will
need to be updated which you're not doing.

Attachment: signature.asc
Description: Digital signature