[RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set

From: Markus Trippelsdorf
Date: Thu Jul 26 2012 - 08:22:47 EST


Every time I start qemu-kvm on my system the following line is added to
the syslog:

vcpu0 unhandled rdmsr: 0xc0010001

AFAICS all calls to vcpu_unimpl only contain debugging info with little
or no value for the end user.

Wouldn't something like the following patch make sense?

Signed-off-by: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index b70b48b..6bd816f 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -321,7 +321,7 @@ struct kvm {
#define kvm_debug(fmt, ...) \
pr_debug("kvm [%i]: " fmt, task_pid_nr(current), ## __VA_ARGS__)
#define kvm_pr_unimpl(fmt, ...) \
- pr_err_ratelimited("kvm [%i]: " fmt, \
+ pr_debug_ratelimited("kvm [%i]: " fmt, \
task_tgid_nr(current), ## __VA_ARGS__)

/* The guest did something we don't support. */

--
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/