Re: [PATCH 16/21] ASoC: Ux500: Enable MOP500 driver for Device Tree

From: Mark Brown
Date: Thu Jul 26 2012 - 07:37:31 EST


On Thu, Jul 26, 2012 at 11:28:49AM +0100, Lee Jones wrote:

> arch/arm/mach-ux500/board-mop500-msp.c | 3 ---
> sound/soc/ux500/mop500.c | 41 ++++++++++++++++++++++++++++++++

There is no binding documentation here. All bindings should be
documented.

> - pr_info("%s: Register platform-device 'snd-soc-u8500'.\n", __func__);
> - platform_device_register(&snd_soc_mop500);
> -

This should be done separately - if it's going to be merged with
something it should be the patch that adds the relevant DT fragments.

Attachment: signature.asc
Description: Digital signature