Re: [PATCH] extcon: extcon_gpio: Replace gpio_request_one bydevm_gpio_request_one

From: Chanwoo Choi
Date: Wed Jul 25 2012 - 02:19:00 EST


On 07/24/2012 10:26 AM, Axel Lin wrote:

> commit 01eaf24 "extcon: Convert extcon_gpio to devm_gpio_request_one"
> missed the replacement for devm_gpio_request_one. fix it.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> drivers/extcon/extcon_gpio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon_gpio.c b/drivers/extcon/extcon_gpio.c
> index fe3db45..3cc152e 100644
> --- a/drivers/extcon/extcon_gpio.c
> +++ b/drivers/extcon/extcon_gpio.c
> @@ -107,7 +107,8 @@ static int __devinit gpio_extcon_probe(struct platform_device *pdev)
> if (ret < 0)
> return ret;
>
> - ret = gpio_request_one(extcon_data->gpio, GPIOF_DIR_IN, pdev->name);
> + ret = devm_gpio_request_one(&pdev->dev, extcon_data->gpio, GPIOF_DIR_IN,
> + pdev->name);
> if (ret < 0)
> goto err;
>

It is right.

Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Thank you,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/