Re: [PATCH] staging: bcm: use SEEK_SET instead of 0 in vfs_llseek

From: Kevin McKinney
Date: Tue Jul 24 2012 - 21:23:11 EST


On Tue, Jul 24, 2012 at 09:25:04PM +0530, Vivek Trivedi wrote:
> They're equivalent, but SEEK_SET seems more informative...
>
> Signed-off-by: Vivek Trivedi <vtrivedi018@xxxxxxxxx>
> Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxx>
> ---
> drivers/staging/bcm/Misc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
> index 8223a69..8fab3ec 100644
> --- a/drivers/staging/bcm/Misc.c
> +++ b/drivers/staging/bcm/Misc.c
> @@ -203,7 +203,7 @@ static int BcmFileDownload(PMINI_ADAPTER Adapter, const char *path, unsigned int
> }
> oldfs = get_fs();
> set_fs(get_ds());
> - vfs_llseek(flp, 0, 0);
> + vfs_llseek(flp, 0, SEEK_SET);

Acked-by: Kevin McKinney <klmckinney1@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/