Re: BUG: tracer_alloc_buffers returned with preemption imbalance

[Paul E. McKenney]

On Sun, Jun 24, 2012 at 01:48:30AM +0800, Fengguang Wu wrote:
> > >  static inline int rcu_blocking_is_gp(void)
> > >  {
> > >         might_sleep();  /* Check for RCU read-side critical section. */
> > > +       preempt_disable();
> > >         return num_online_cpus() <= 1;
> > > +       preempt_enable();
> > >  }
> > 
> > Thank you!  I have no idea how a preempt_disable() causes that badness
> > to happen, but this commit is not yet critically important, so I will
> > drop it.
> 
> preempt_enable() becomes dead code because of the return statement?
> I wonder why gcc didn't issue a warning (or I failed to catch it)...

Color me blind and stupid!!!  Thank you, will fix.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/