Re: [net-next:master 49/50]net/netfilter/nfnetlink_queue_ct.c:23:18: sparse: incompatible types incomparison expression (different address spaces)
From: Pablo Neira Ayuso
Date: Fri Jun 22 2012 - 20:42:06 EST
On Tue, Jun 19, 2012 at 02:00:50PM +0800, wfg@xxxxxxxxxxxxxxx wrote:
> Hi Pablo,
>
> There are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head: 6bdc5f49e365a5403b9fdef01ceb37241ab00f9b
> commit: 7c62234547255ce4c385a218915965bc2f14fe45 [49/50] netfilter: nfnetlink_queue: fix compilation with NF_CONNTRACK disabled
>
> All sparse warnings:
>
> net/netfilter/nfnetlink_queue_ct.c:23:18: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nfnetlink_queue_ct.c:45:18: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nfnetlink_queue_ct.c:63:18: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nfnetlink_queue_ct.c:91:18: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nf_conntrack_netlink.c:1100:27: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nf_conntrack_netlink.c:1222:34: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nf_conntrack_netlink.c:1222:34: sparse: incompatible types in comparison expression (different address spaces)
>
> net/netfilter/nfnetlink_queue_ct.c:23:
> 20 struct nf_conn *ct;
> 21
> 22 /* rcu_read_lock()ed by __nf_queue already. */
> > 23 nfq_ct = rcu_dereference(nfq_ct_hook);
> 24 if (nfq_ct == NULL)
> 25 return NULL;
> 26
JFYI: I've enqueued the following patch to fix this sparse warning:
http://1984.lsi.us.es/git/nf-next/commit/?id=5a05fae5ca7cd5279567747fc34d60413b504cd6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/