Re: Linux 2.6.32.55

From: Willy Tarreau
Date: Fri Jun 22 2012 - 17:18:28 EST


On Fri, Jun 22, 2012 at 11:10:25PM +0200, Jiri Slaby wrote:
> On 06/22/2012 09:38 PM, Greg KH wrote:
> > On Fri, Jun 22, 2012 at 09:04:03PM +0200, Jiri Slaby wrote:
> >> On 01/25/2012 11:34 PM, Greg KH wrote:
> >>> I'm announcing the release of the 2.6.32.55 kernel.
> >> ...
> >>> Bjorn Helgaas (1): PNP: work around Dell 1536/1546 BIOS MMCONFIG
> >>> bug that breaks USB
> >>
> >> Hi, this one is dependant on 24d25dbfa63c3 (x86/PCI: amd: factor out
> >> MMCONFIG discovery), otherwise amd_get_mmconfig_range is undefined...
> >
> > Interesting that this was reported almost 6 months after it was released :)
>
> Yes :). This is because it is inside #ifdef CONFIG_AMD_NB which perhaps
> nobody has set in 2.6.32. (Other than that we have the kernel in suse
> enterprise for some time already.)
>
> @Willy: 24d25dbfa63c3 is not enough. The header referenced in
> 2.6.32.55's patch does not exist in that tree yet. It was renamed from
> asm/k8.h to asm/amd_nb.h later (by 23ac4ae827e62).
>
> Given nobody noticed till now, I would incline to drop that patch from
> 2.6.32 series. Opinions?

Which one would you drop then ? You got me lost now. I mean, since you've
been the only one to notice an issue, I have no problem with following you
on the best way to fix it but I need to understand what you want then :-)

Thanks,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/