Re: [PATCH][RT] spinlock: Add include for BUG() in spinlock_rt.h

From: Thomas Gleixner
Date: Fri Jun 22 2012 - 05:08:49 EST


On Thu, 21 Jun 2012, Steven Rostedt wrote:

> spinlock_rt.h references BUG(), but it does not include bug.h, and on
> some architectures (powerpc) this can cause a build failure.
>
> Reported-by: Iratxo Pichel Ortiz <ipichel@xxxxxxxxxxxx>
> Reported-by: leroy christophe <christophe.leroy@xxxxxx>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> ----
> [ Thomas, can you add this patch to your queue so that I can add it to
> stable. Please, let me know when you have. Thanks! ]

Picked it up, thanks. Please take it right away w/o waiting for my
release.

Thanks,

Thomas


> diff --git a/include/linux/spinlock_rt.h b/include/linux/spinlock_rt.h
> index 3b555b4..0618387 100644
> --- a/include/linux/spinlock_rt.h
> +++ b/include/linux/spinlock_rt.h
> @@ -5,6 +5,8 @@
> #error Do not include directly. Use spinlock.h
> #endif
>
> +#include <linux/bug.h>
> +
> extern void
> __rt_spin_lock_init(spinlock_t *lock, char *name, struct lock_class_key *key);
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/