Re: [PATCH] x86, cpufeature: Fix duplicate feature name "dts"

[Ingo Molnar]

* H. Peter Anvin <hpa@xxxxxxxxxxxxxxx> wrote:

> On 06/21/2012 11:44 AM, Borislav Petkov wrote:
> > On Thu, Jun 21, 2012 at 11:06:04AM -0700, H. Peter Anvin wrote:
> >> On 06/21/2012 10:07 AM, Jean Delvare wrote:
> >>>
> >>> And FWIW, X86_FEATURE_DS has no user in the kernel. Doesn't look like a
> >>> key feature to me, but maybe my view is biased...
> >>>
> >>
> >> No, but apparently perfmon2 depends on it, in userspace, and it relies
> >> on the string.
> >>
> >> So this is a nonstarter.
> > 
> > Maybe call the sensor thing "dtsen" or something similarly short but not
> > "dts"?
> > 
> 
> Yeah, that's what we have to do.  Sigh.

Plus add a kernel build time check to avoid such string clashes 
in the future? These acronyms tend to be short and hard to read, 
I'd not be surprised if this repeated in the future.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/