Re: [PATCH V3 2/3] regulator: dt: regulator match byregulator-compatible

From: Mark Brown
Date: Thu Jun 21 2012 - 18:52:30 EST


On Thu, Jun 21, 2012 at 09:03:29PM +0000, Arnd Bergmann wrote:

> The board specific settings on the other hand are about what to
> put into those registers and what voltage to use. From all I can
> tell, those settings belong into the node that actually uses the
> regulator, not the node that defines it.

This doesn't work. Each regulator may be used by multiple consumers,
the configuration is for the supply as a whole not for an individual
user. The main service the API is providing is arbitration between
multiple consumers and the physical capabilities of the board.

Due to the fact that the binding of the device has to be done by the
board you'd need to replace the regulator-compatible value with a
phandle pointing to whatever nodes the .dtsi defines (and which would
need to include some string as well so we can bind code to it). And of
course if anyone wants to use the device on a non-DT architecture we'd
need to replicate everything in code anyway.

Attachment: signature.asc
Description: Digital signature