Re: [PATCH] SPI: at25: Parse dt settings

[Alexandre Pereira da Silva]

On Thu, Jun 21, 2012 at 6:49 AM, Ivo Sieben <meltedpianoman@xxxxxxxxx> wrote:
> One small remark:
> In case of platform_data, the "if (!chip)" check has been removed and
> is now only handled in the device tree initialization.
> Maybe add this check to the platform initialization as well:
>
> } else {
>        if (!spi->dev.platform_data) {
>                dev_dbg(&spi->dev, "no chip description\n");
>                err = -ENODEV;
>                goto fail;
>        }
>        chip =  *(struct spi_eeprom *)spi->dev.platform_data;
> }

Thanks for finding that out. I will fix that case.

This patch was already merged to gregh/char-misc:
http://git.kernel.org/?p=linux/kernel/git/gregkh/char-misc.git;a=shortlog;h=refs/heads/char-misc-next

I will implement a patch to fix this against the original one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/