Re: [PATCH] usb: host: xhci: Compliance Mode port recovery

From: Greg KH
Date: Wed Jun 20 2012 - 20:32:32 EST


On Wed, Jun 20, 2012 at 05:07:34PM -0700, Sarah Sharp wrote:
> > Unfortunately there is not a way to programmatically detect if the re-driver
> > is present on the system, and since it might affect any host controller, I'm
> > afraid this workaround can't be limited on the driver to specific hardware.
>
> Ok, then make it a module parameter that is off by default. Users who
> find they have this issue can reload the driver with the timer on, and
> add the module parameter to their grub linux boot line. If we find that
> the redriver is used always for one particular host vendor/revision,
> we'll add a quirk for it.
>
> But I really don't want an extra timer running and killing power
> management for hosts that don't need this work around.

I don't want that either, but I really don't want a new module parameter
that no one is going to know that they need to set.

I think the real solution is finding what pci devices this is a problem
with, and using a quirk that way.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/