Re: [PATCH 09/12] nfs: disable data cache revalidation for swapfiles

From: Rik van Riel
Date: Wed Jun 20 2012 - 13:17:27 EST


On 06/20/2012 05:37 AM, Mel Gorman wrote:
The VM does not like PG_private set on PG_swapcache pages. As suggested
by Trond in http://lkml.org/lkml/2006/8/25/348, this patch disables
NFS data cache revalidation on swap files. as it does not make
sense to have other clients change the file while it is being used as
swap. This avoids setting PG_private on swap pages, since there ought
to be no further races with invalidate_inode_pages2() to deal with.

Since we cannot set PG_private we cannot use page->private which
is already used by PG_swapcache pages to store the nfs_page. Thus
augment the new nfs_page_find_request logic.

Signed-off-by: Peter Zijlstra<a.p.zijlstra@xxxxxxxxx>
Signed-off-by: Mel Gorman<mgorman@xxxxxxx>

Acked-by: Rik van Riel<riel@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/