Re: [PATCH V2 3/3] staging/rtl8192u: use for loop to assign bitshifted addr

[devendra.aaru]

Hi Joe,

On Wed, Jun 20, 2012 at 12:49 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> It's also got a bit of code duplication.
> Maybe something like:
>
>        if (priv->epromtype == EPROM_93c56) {
>                addr_len = 8;
>        else
>                addr_len = 6;
>
>        test_bit = 1 << (addr_len - 1);
>        for (i = 0; i < addr_len; i++) {
>                addr_str[i] = addr & test_bit;
>                test_bit >>= 1;
>        }
>
Ahhh, true.

V3 sending :-)

Thanks,
Devendra.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/