Re: [PATCH 01/10] zcache: fix preemptable memory allocation in atomiccontext

[Xiao Guangrong]

On 06/19/2012 10:26 PM, Seth Jennings wrote:


> Did you get a might_sleep warning on this?  I haven't seen this being an
> issue.
> 


No, i did not, i get it just from code review.

> GFP_ATOMIC only modifies the existing mask to allow allocation use the
> emergency pool.  It is __GFP_WAIT not being set that prevents sleep.  We
> don't want to use the emergency pool since we make large, long lived
> allocations with this mask.
> 


Ah, yes, i thought only GFP_ATOMIC can prevent sleep, thank you very much
for pointing it out.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/