Re: [PATCH] x86, microcode: Make reload interface per system

From: Borislav Petkov
Date: Tue Jun 19 2012 - 11:06:17 EST


On Tue, Jun 19, 2012 at 12:26:08PM +0200, Peter Zijlstra wrote:
> On Tue, 2012-06-19 at 12:22 +0200, Borislav Petkov wrote:
> >
> > But I haven't tested what happens when it is built in and I use the
> > reload interface, hehe something to play with today.
>
> I couldn't easily find where to place the damn ucode image anyway, so I
> built in the old-style /dev interface and used the microcode.ctl package
> to load it.
>
> Fwiw, that works just fine when its built-in.

Ok, so something changed in the request_firmware thing in the meantime.
Last time I checked we waited for 60 seconds to get the ucode blob from
userspace but that wasn't happening that early in the boot process so we
continued without newer ucode patch.

Now we load the ucode driver very early if it is built-in (look at
printk timestamps):

[ 3.651275] microcode: CPU0: patch_level=0x010000c4
[ 3.664943] microcode: CPU1: patch_level=0x010000c4
[ 3.670177] microcode: CPU2: patch_level=0x010000c4
[ 3.675407] microcode: CPU3: patch_level=0x010000c4
...

and then later, when we have userspace, we can use the reload thing to
re-request microcode. Which is also fine, I guess.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/