Re: Why does ionice(1) ban the user to set back to 'none' class?

From: gnehzuil.lzheng@xxxxxxxxx
Date: Tue Jun 19 2012 - 04:15:57 EST


On 06/19/2012 02:40 PM, Bernhard Voelker wrote:

> That has already been fixed by commit v2.15-45-g5dc9371 more than 2 years ago:
>
> Author: Jakob Unterwurzacher <jakobunt@xxxxxxxxx> 2009-01-17 02:38:32
> Committer: Karel Zak <kzak@xxxxxxxxxx> 2009-05-27 23:43:18
>
> and the change made it into 2.16.
>
> The current piece of code looks like this:
>
> switch (ioclass) {
> case IOPRIO_CLASS_NONE:
> if ((set & 1) && !tolerant)
> warnx(_("ignoring given class data for none class"));
> data = 0;
> break;
> case IOPRIO_CLASS_RT:
> case IOPRIO_CLASS_BE:
> break;
>
> We'are currently at version 2.21.2.

Thanks for pointing out it. I use ionice(1) in rhel5 and its version is
2.13. :-p

Obviously, Documentation/block/ioprio.txt is out of date. Later I will
send a patch to fix it.

Regards,
Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/