Re: [PATCH] perf stat: Fix default logfd to use stderr

[Stephane Eranian]

On Tue, Jun 19, 2012 at 4:13 AM, Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> Hi, Robert
>
> On Mon, 18 Jun 2012 16:51:08 +0200, Robert Richter wrote:
>> On 29.09.11 18:48:01, Arnaldo Carvalho de Melo wrote:
>>> From: Jim Cromie <jim.cromie@xxxxxxxxx>
>>>
>>> This perf stat option emulates valgrind's --log-fd option, allowing the
>>> user to send perf results elsewhere, and leaving stderr for use by the
>>> program under test. ÂThis complements --output file option, and is
>>> mutually exclusive with it.
>>>
>>> Â Â3>results Âperf stat --log-fd 3 Â Â Â Â Â-- $cmd
>>> Â Â3>>results perf stat --log-fd 3 --append -- $cmd
>>>
>>> The perl distro's make test.valgrind target uses valgrind's --log-fd
>>> option, I've adapted it to invoke perf also, and tested this patch
>>> there.
>>>
>>> Link: http://lkml.kernel.org/r/1315437244-3788-2-git-send-email-jim.cromie@xxxxxxxxx
>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>>> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>>
>> With certain shell redirections this (56f3bae) fails with a log fd
>> setup failure. Fix below.
>>
>
> It looks somewhat related to Stephane's patch. Can you we check it too?
>
> http://lkml.indiana.edu/hypermail/linux/kernel/1205.1/04232.html
>
Yes, my patch is needed and it was posted over a month ago now.....
Arnaldo, please apply my patch.

> Thanks,
> Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/