Re: [ 04/69] drm/i915: fix up ivb plane 3 pageflips

[Ben Hutchings]

On Mon, 2012-06-18 at 19:10 -0300, Eugeni Dodonov wrote:
> On 06/18/2012 06:55 PM, Herton Ronaldo Krzesinski wrote:
> >> +	default:
> >> +		WARN_ONCE(1, "unknown plane in flip command\n");
> >> +		ret = -ENODEV;
> >> +		goto err;
> > 
> > Shouldn't this have been "goto err_unpin;"?
> > 
> > It's not a problem in the backport for 3.2, same code is in the original
> > patch, just noticed it seems a problem while looking at it; but by what
> > changelog says the default case is said to not trigger in "practice"
> > (catch programming error), so I think it doesn't pose a real issue in
> > practice.
> 
> You are right, it should be err_unpin. I sent a patch rectifying this.
> 
> In practice, this should not happen, but still, better be safe than
> sorry. Thanks for catching that!

So should I drop this until the second patch is upstream?

Ben.

-- 
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.

Attachment: signature.asc
Description: This is a digitally signed message part