Re: [PATCH 2/3] usb: gadget: mass_storage: fail fsg_store_file() early if colud not open file

[Alan Stern]

On Mon, 18 Jun 2012, Michal Nazarewicz wrote:

> From: Michal Nazarewicz <mina86@xxxxxxxxxx>
> 
> Currently, when a new value is stored to the âfileâ sysfs entry,
> fsg_store_file() will release existing backing file and only then attempt to
> open a new one.  If that fails, no new backing file is open.
> 
> This commit changes the fsg_lun_open() so that it closes existing backing file
> only after the new backing file has been successfully opened.  With that
> change, fsg_store_file() may use it to perform an atomic open operation with
> guarantee that logical unit will either point to the new backing file or still
> to the old one.

This is a good idea.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/