Re: Q: return of pinctrl_register and handing at drivers that usethis function

From: devendra.aaru
Date: Mon Jun 18 2012 - 08:04:48 EST


Hi Linus,

On Mon, Jun 18, 2012 at 5:22 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Mon, Jun 18, 2012 at 1:47 PM, devendra.aaru <devendra.aaru@xxxxxxxxx> wrote:
>
>> since the pinctrl_register returns a pointer of structure type "struct
>> pinctrl_dev" or NULL if it was failed to register the pinctrl driver,
>> so IS_ERR checking is not required?
>
> Yes. (Unless I did something wrong.)
>
So checking the return value of pinctrl_register with IS_ERR is not required.
There are drivers in pinctrl subsystem which uses the IS_ERR and may (not)
check whether its null or not.

you can expect a patchset of those fixes. :)
> Yours,
> Linus Walleij

Thanks,
Devendra.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/