Re: [patch] BFS 420: a tiny step forward

[Hillf Danton]

On Sun, Jun 17, 2012 at 6:46 PM, Emmanuel Benisty <benisty.e@xxxxxxxxx> wrote:
> Hi Hillf,
>
> On Thu, Jun 7, 2012 at 8:05 PM, Hillf Danton <dhillf@xxxxxxxxx> wrote:
>> On Thu, Jun 7, 2012 at 8:37 PM, Hillf Danton <dhillf@xxxxxxxxx> wrote:
>>> Hi Emmanuel
>>>
>>> On Wed, Jun 6, 2012 at 11:51 PM, Emmanuel Benisty <benisty.e@xxxxxxxxx> wrote:
>>>>
>>>> Unfortunately, the issue is still there.
>>>>
>>> Hang at same place?
>>>
>> And try to revert handling CPU_ONLINE, please.
>>
>>
>> --- a/kernel/sched/bfs.c    ÂSat Jun Â2 17:30:28 2012
>> +++ b/kernel/sched/bfs.c    ÂThu Jun Â7 20:58:36 2012
>> @@ -5352,7 +5352,7 @@ migration_call(struct notifier_block *nf
>> Â Â Â Â Â Â Â Â/* Update our root-domain */
>> Â Â Â Â Â Â Â Âgrq_lock_irqsave(&flags);
>> Â Â Â Â Â Â Â Âif (rq->rd) {
>> - Â Â Â Â Â Â Â Â Â Â Â BUG_ON(cpumask_test_cpu(cpu, rq->rd->span));
>> + Â Â Â Â Â Â Â Â Â Â Â BUG_ON(!cpumask_test_cpu(cpu, rq->rd->span));
>>
>> Â Â Â Â Â Â Â Â Â Â Â Âset_rq_online(rq);
>> Â Â Â Â Â Â Â Â}
>> --
>
> Sorry for the late reply. This patch did solve the issue, thanks.
>
Thank you, Emmanuel.
It is good news before 421-1 is released next week:)

		Hillf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/