Re: [PATCH] Use test_and_clear_bit() instead atomic_dec_and_test() for stop_machine

From: OGAWA Hirofumi
Date: Thu Jun 07 2012 - 09:18:10 EST


Steven Rostedt <rostedt@xxxxxxxxxxx> writes:

> On Wed, 2012-05-23 at 13:19 +0900, OGAWA Hirofumi wrote:
>> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> writes:
>>
>> >> The down side to this is that it adds 4 more bytes on a 64bit
>> >> machine. (sizeof(unsigned log) == 8 and sizeof(atomic_t) == 4)
>>
>> Another patch without additional 4bytes. This simply change
>> atomic_dec_and_test() to atomic_xchg().
>>
>
> If nobody picked this up, you might want to resend it with my acked-by.
> (The second patch, not the first). As patches added to replies are
> usually ignored.

Thanks. I was going to add that to my personal patchset, I will try it again.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/