Re: [PATCH] driver core: fix shutdown races with probe/remove

From: Greg Kroah-Hartman
Date: Tue Jun 05 2012 - 05:19:03 EST


On Tue, Jun 05, 2012 at 04:59:07PM +0800, Ming Lei wrote:
> Firstly, .shutdown callback may touch a uninitialized hardware
> if dev->driver is set and .probe is not completed.

When would that ever happen?

> Secondly, device_shutdown() may dereference a null pointer to cause
> oops when dev->driver is cleared after it is checked in device_shutdown().

Again, when would that happen? A new device/driver being added to the
system as it is being shutdown?

Has anyone ever hit that before?

Is this really needed?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/