Re: [PATCH v2 10/10] ext4: use memweight()

From: Akinobu Mita
Date: Sun Jun 03 2012 - 08:57:41 EST


2012/6/2 Andreas Dilger <adilger@xxxxxxxxx>:
> On 2012-06-02, at 7:40, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
>
>> Use memweight() to count the total number of bits clear in memory area.
>> This change only affects the code segments enabled by EXT4FS_DEBUG.
>
> Personally, I'd rather still keep a thin wrapper ext4_count_free() and put the memweight() call and math inside that. The function name ext4_count_free() is meaningful to readers, while memweight() is much less so.

OK, I'll make such change to ext[234] if no other people disagree with it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/