Re: [PATCH 2/2] 8139cp/8139too: terminate the eeprom access withthe right opmode

From: David Miller
Date: Fri Jun 01 2012 - 14:23:19 EST


From: Jason Wang <jasowang@xxxxxxxxxx>
Date: Fri, 01 Jun 2012 12:19:48 +0800

> Currently, we terminate the eeprom access through clearing the CS by:
>
> RTL_W8 (Cfg9346, ~EE_CS); or writeb (~EE_CS, ee_addr);
>
> This would left the eeprom into "Config. Register Write Enable:"
> state which is not expcted as the highest two bits were set to
> 0x11 ( expected is the "Normal" mode (0x00)). Solving this by write
> 0x0 instead of ~EE_CS when terminating the eeprom access.
>
> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/