Re: [PATCH] vfs: fix IMA lockdep circular locking dependency

[Al Viro]

On Wed, May 30, 2012 at 05:40:54PM -0700, Linus Torvalds wrote:
> On Wed, May 30, 2012 at 5:28 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > FWIW, I think it's cleaner to take the whole thing into an inlined helper.
> 
> Even better.
> 
> I notice that your inlined helper doesn't do what I did: if PROT_EXEC
> is already set, stop all the stupid games. IOW, the first test in that
> function could as well be
> 
>     if (prot & (PROT_READ | PROT_EXEC) != PROT_READ)
>         return prot;
> 
> because if PROT_EXEC is already set, or if PROT_READ wasn't set, none
> of the rest of the checks make any sense at all.

Point...  OK, done, pushed and the whole thing thrown into #for-next.
Probably too late for today's linux-next, but tomorrow one should pick
that.  BTW, tomorrow there'll be a signal.git pull request as well,
with task_work_add() series in it.

Now for the Miklos' stuff...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/