Re: [PATCH] prctl: Removed redunant assignment of "error" to zero

[Kees Cook]

On Wed, May 30, 2012 at 2:55 AM, Sasikantha babu
<sasikanth.v19@xxxxxxxxx> wrote:
> Just setting the "error" to error number is enough on failure and
> It doesn't require to set "error" variable to zero in each switch case, since
> it was already initialized with zero

This looks fine. Can you include an additional clean up in this? It
looks like PR_SET_NAME and PR_GET_NAME both 'return 0' instead of
using 'break' like all the rest.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/