Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry

From: Lee Jones
Date: Tue May 29 2012 - 11:38:03 EST


On 29/05/12 23:27, Samuel Ortiz wrote:
Hi Lee,

On Tue, May 29, 2012 at 11:06:23PM +0800, Lee Jones wrote:
On 29/05/12 18:52, Samuel Ortiz wrote:
Hi Lee,

On Tue, May 29, 2012 at 05:27:22PM +0800, Lee Jones wrote:
Hi Sam,

On Tue, May 29, 2012 at 04:29:21PM +0800, Lee Jones wrote:
On 29/05/12 15:53, Axel Lin wrote:
2012/5/29 Lee Jones<lee.jones@xxxxxxxxxx>:
On 29/05/12 14:19, Axel Lin wrote:

config AB8500_I2C_CORE is not used after commit d28f1db
"mfd: Remove confusing ab8500-i2c file and merge into ab8500-core".
Thus remove it.

Signed-off-by: Axel Lin<axel.lin@xxxxxxxxx>


I have this patch embedded into a patch-set I'm going to send to ARM-SoC for
inclusion into -rc1 this afternoon. Would you mind leaving this one?

I don't mind.
But AFAIK, commit d28f1db is in mfd tree.
Any reason you want to send the patch to ARM-SoC instead of mfd tree.

I don't actually have a preference as to which tree it goes into, so
long as it's sent to Mainline on or before -rc1.
I sent a pull request to Linus yesterday, including this commit.

This is something different and wasn't part of the pull-request.
d28f1d was part of the pull request.

Right. But this is not the same thing. The patch I (and Axel) wrote
removes remnant cruft from d28f1d. I didn't see that on moving
AB8500_I2C_CORE to AB8500_CORE I left a Kconfig entry behind which
is no longer used by anything. This patch removes that cruft.
Yes, I saw the patch. I though you were saying that d28f1d was not part of the
pull request and that you were going to push it through arm-soc.
Anyway, I think the Kconfig cleanup patch should go through my tree unless you
already sent it for arm-soc inclusion.

I haven't. I sent the entire patch-set to Arnd for first review today. After he's okay:ed it, I'll send it to the MLs sometime tomorrow. I will ensure you are CC'ed. I don't have any issues with the patch going through your tree.

Thanks Sam.

Kind regards,
Lee

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/