Re: [PATCH] misc: emif: fix compilation error

From: Felipe Balbi
Date: Fri May 25 2012 - 05:30:57 EST


On Fri, May 25, 2012 at 02:40:18PM +0530, Shilimkar, Santosh wrote:
> On Fri, May 25, 2012 at 1:41 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> > commit 99d3eccf (ARM: OMAP4/5: EMIF: Probe
> > Emif driver with initcall) introduced a compile
> > error by not removing module_init() when adding
> > postcore_initcall().
> >
> > This problem would've been caught by just compiling
> > the driver as module.
> >
> > Fix the issue by removing module_init() from the
> > driver.
> >
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > ---
> >  drivers/misc/emif.c |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/misc/emif.c b/drivers/misc/emif.c
> > index 36fda8e..8725ea9 100644
> > --- a/drivers/misc/emif.c
> > +++ b/drivers/misc/emif.c
>
> This driver is in drivers/memory now and this patch is
> certainly not applicable. Looks like you might have seen
> this issue with the older, internal version of the driver.

could be.. I probably merged something I shouldn't on my master branch
;-)

Weird is that my master is built on top of v3.4... anyway.. forget about
this patch, sorry for the noise.

--
balbi

Attachment: signature.asc
Description: Digital signature