Re: [git pull] Input updates for 3.5-rc0

From: Dmitry Torokhov
Date: Thu May 24 2012 - 17:38:16 EST


On Thu, May 24, 2012 at 02:07:29PM -0700, Linus Torvalds wrote:
> On Thu, May 24, 2012 at 1:59 PM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
> >
> > I was concerned about the _next_ device (the one that will be created
> > the moment I plug in the tablet back into the same port) having exact
> > same name as the one that is half dead and clashing in sysfs and
> > elsewhere. We used to have issues with this.
>
> Ok, that's certainly a valid concern.
>
> It's still - I think - really sad/wrong that the device name is then
> so useless than the drivers end up basically not using it.

I can see the desire for logging, it is just hard to come with good
automatic way of doing this without burdening drivers, given that errors
happen rarely in input core layer and in driver code we already have
perfect device object to report against.

Maybe dev_XXX() should report full sysfs path do the dveice? Still does
not help with the fact that "driver" shown for class devices is not so
interesting as it will always be the class name.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/