Re: [PATCH v7 8/8] x86/tlb: just do tlb flush on one of siblingsof SMT

From: Alex Shi
Date: Thu May 24 2012 - 04:50:19 EST


On 05/24/2012 04:42 PM, Peter Zijlstra wrote:

> On Thu, 2012-05-24 at 16:32 +0800, Alex Shi wrote:
>> So, I use cpumask_t in stack.
>
> cpumask_t is 512 bytes with NR_CPUS=4096, that's generally considered
> too big to be on stack.
>
> A number of people spend a lot of time removing cpumask_t from stacks a
> while ago, I'm very sure they'll not be happy if you're going to add it
> back.


In my testing, allocate a cpumask_var_t is more worse than cpumask_t.
So, another choice is using percpu pre-allocatd cpumask for this, but I
am wondering if it is acceptable. What's suggestion for this point?

>
> Rusty, what was the plan on removing cpumask_t altogether?
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/