Re: [PATCH v2] leds: add new transient trigger for one shot timeractivation

From: NeilBrown
Date: Thu Apr 26 2012 - 02:02:32 EST


On Wed, 25 Apr 2012 11:42:38 -0600 Shuah Khan <shuahkhan@xxxxxxxxx> wrote:

> There was a suggestion to change units to seconds similar to "safe_delay_show"
> and "safe_delay_store" in drivers/md/md.c. safe_delay_show shows time in
> seconds, however safe_delay_store still takes the value in msecs. This
> sounded like an asymmetric interface.

I don't think you read the code properly. "strict_strtoul_scaled" takes
a number like "0.20" and scales it to an integer...
(though your decision not to take that approach may still be justified).

NeilBrown

Attachment: signature.asc
Description: PGP signature