Re: [PATCH 2/4][Trivial] lib/kobject.c : Check parameter inkobject_set_name

From: greg
Date: Mon Apr 23 2012 - 16:39:25 EST


On Sat, Apr 21, 2012 at 05:31:24PM +0800, yan wrote:
> kobject_set_name is exported and is just a wrapper for kobject_set_name_vargs
> which does not check its parameter kobj.
> So check this parameter in kobject_set_name.

I have the same objection to this patch, why is it needed? All
in-kernel users do this properly, so the patch isn't needed.

Remember, kernel programming isn't always about being defensive.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/