Re: [PATCH 05/16] sched: SCHED_DEADLINE policy implementation.

[Juri Lelli]

On 04/23/2012 04:35 PM, Peter Zijlstra wrote:
> On Fri, 2012-04-06 at 09:14 +0200, Juri Lelli wrote:
> > +static void init_dl_task_timer(struct sched_dl_entity *dl_se)
> > +{
> > +       struct hrtimer *timer =&dl_se->dl_timer;
> > +
> > +       if (hrtimer_active(timer)) {
> > +               hrtimer_try_to_cancel(timer);
> > +               return;
> > +       }
>
> Same question I guess, how can it be active here? Also, just letting it
> run doesn't seem like the best way out..

Probably s/hrtimer_try_to_cancel/hrtimer_cancel is better.
 
> > +
> > +       hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> > +       timer->function = dl_task_timer;
> > +       timer->irqsafe = 1;
> > +}

Thanks,

- Juri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/