Re: [PATCH 14/17] hpsa: use new IS_ENABLED macro

[Stephen Cameron]

On Sun, Apr 22, 2012 at 1:12 PM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:
> On Fri, Apr 20, 2012 at 11:07 AM, Stephen M. Cameron
> <scameron@xxxxxxxxxxxxxxxxxx> wrote:
>> From: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
>>
>> Signed-off-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
>
> You've not written a commit log, so I'm left guessing what the
> intended rationale is here.  COMPAT, X86 and PCI_MSI are
> I believe all bool, so why make this change?  To me it gives
> a misleading message that some level of modular awareness
> is needed here, when there really isn't any such need.

Well, I saw this commit go by: 69349c2dc01c489eccaa4c472542c08e370c6d7e

   Using IS_ENABLED() within C (vs.  within CPP #if statements) in its
   current form requires us to actually define every possible bool/tristate
   Kconfig option twice (__enabled_* and __enabled_*_MODULE variants).
   [...]

and so I kind of thought IS_ENABLED is the new way to do that sort of thing.

Perhaps I'm wrong about that.  Obviously the patch is not _needed_ for
things to work.

-- steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/