Re: [PATCH 0/3] hid: Enable report fixup on rebind

From: Jiri Kosina
Date: Sun Apr 22 2012 - 17:27:09 EST

On Sun, 22 Apr 2012, Henrik Rydberg wrote:

> This patchset contains a resolution to the problem with
> driver-specific modification of the report descriptor. The core of the
> problem lies with the dual semantics of hid_parse_report(), which is
> therefore split into two functions. As a consequence, the hid core can
> handle the rebind case internally, with no changes to the
> drivers. Out-of-tree drivers will work fine as long as they operate in
> the same way as the in-kernel drivers.
> The first two patches are bug fixes found in the process. I am hoping
> for some test feedback on those. The third patch is the main one.

Hi Henrik,

thanks a lot for looking into this. I will look into the patches in more
detail tomorrow. I am now just adding Nikolai to CC, as he was the first
one to bring this up and actually has a driver that exposed the fact that
just freeing/reinstatiating rdesc is not enough.


> Henrik Rydberg (3):
> hid-hyperv: Do not use hid_parse_report() directly
> hid-logitech: Collect report descriptors before sending
> hid: Handle driver-specific device descriptor in core
> drivers/hid/hid-core.c | 112 +++++++++++++++++++++++++++++++++--------
> drivers/hid/hid-hyperv.c | 14 +++++-
> drivers/hid/hid-logitech-dj.c | 71 +++++++++++---------------
> include/linux/hid.h | 14 ++----
> 4 files changed, 135 insertions(+), 76 deletions(-)
> --
> 1.7.10

Jiri Kosina
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at