Re: [PATCH] drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:add missing free_netdev

[Julia Lawall]

On Sun, 22 Apr 2012, Sean MacLennan wrote:

> On Sun, 22 Apr 2012 14:02:13 +0200
> Julia Lawall <Julia.Lawall@xxxxxxx> wrote:
>
> > From: Julia Lawall <Julia.Lawall@xxxxxxx>
> >
> > Free dev on failure as done elsewhere in the function.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
> >
> > ---
> >  drivers/staging/rtl8192u/ieee80211/ieee80211_module.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> > b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index
> > e3d47bc..82d4bf6 100644 ---
> > a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++
> > b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -161,7
> > +161,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv) if
> > (ieee->pHTInfo == NULL) {
> >  		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc
> > memory for HTInfo\n");
> > -		return NULL;
> > +		goto failed;
> >  	}
> >  	HTUpdateDefaultSetting(ieee);
> >  	HTInitializeHTInfo(ieee); //may move to other place.
>
> It looks like the rtl8192e/rtllib_module.c alloc_rtllib has the same
> error. They probably where based on the same function.

Thanks for the pointer.  I will take a look.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/