Re: [PATCH 12/17] ARM clps711x: Simple optimise debug_macro by removing one NOP

From: Arnd Bergmann
Date: Sat Apr 21 2012 - 07:19:25 EST

On Saturday 21 April 2012, Alexander Shiyan wrote:
> .macro addruart, rp, rv, tmp
> - mov \rp, #0x0000 @ UART1
> -#else
> - mov \rp, #0x1000 @ UART2
> + mov \rp, #0x1000 @ Add offset for UART2 base reg
> #endif
> orr \rv, \rp, #CLPS711X_VIRT_BASE
> orr \rp, \rp, #CLPS711X_PHYS_BASE

This looks wrong at first sight. Is rp guaranteed to be zero when calling
the macro? Am I misreading this? Sorry my ARM assembly skill is still horrible.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at