[PATCH 4/4][Trivial] lib/kobject.c : check parameter inkobject_init_and_add

From: yan
Date: Sat Apr 21 2012 - 06:18:27 EST

If user turns to the simple interface kobject_init_and_add
and gives a null kobject, kobject_init can detect it but
just dumps the stack. Then there is:
In the end, it will reference kobj->name and we have an oops.

Check whether we have a valid kobject in kobject_init_and_add.

Signed-off-by: Yan Hong <clouds.yan@xxxxxxxxx>
lib/kobject.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/lib/kobject.c b/lib/kobject.c
index dd67855..bc05922 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -380,6 +380,9 @@ int kobject_init_and_add(struct kobject *kobj, struct kobj_type *ktype,
va_list args;
int retval;

+ if (!kobj)
+ return -EINVAL;
kobject_init(kobj, ktype);

va_start(args, fmt);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/