RE: [PATCH 04/17] hpsa: suppress excessively chatty error messages

[Shergill, Gurinder]

| -----Original Message-----
| From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-
| owner@xxxxxxxxxxxxxxx] On Behalf Of Stephen M. Cameron
| Sent: Friday, April 20, 2012 8:07 AM
| To: james.bottomley@xxxxxxxxxxxxxxxxxxxxx
| Cc: linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Gates, Matt;
| stephenmcameron@xxxxxxxxx; thenzl@xxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx;
| mikem@xxxxxxxxxxxxxxxxxx
| Subject: [PATCH 04/17] hpsa: suppress excessively chatty error messages
| 
| From: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
| 
| Default behavior for any CHECK CONDITION excepting a few special cases is
| to print out certain parts of the sense buffer and the CDB.  Default
| behavior should be to print nothing and let the upper layers or
| applications decide what to do about these.  The same information is
| already available by setting the appropriate bits of the
| scsi_logging_level kernel parameter or via
| /proc/sys/dev/scsi/logging_level.

Makes sense.

| 
| Signed-off-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
| ---
|  drivers/scsi/hpsa.c |    2 +-
|  1 files changed, 1 insertions(+), 1 deletions(-)
| 
| diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index
| 906672b..fcb9fb2 100644
| --- a/drivers/scsi/hpsa.c
| +++ b/drivers/scsi/hpsa.c
| @@ -1193,7 +1193,7 @@ static void complete_scsi_command(struct CommandList
| *cp)
|  				break;
|  			}
|  			/* Must be some other type of check condition */
| -			dev_warn(&h->pdev->dev, "cp %p has check condition: "
| +			dev_dbg(&h->pdev->dev, "cp %p has check condition: "
|  					"unknown type: "
|  					"Sense: 0x%x, ASC: 0x%x, ASCQ: 0x%x, "
|  					"Returning result: 0x%x, "
| 

Few lines further down in the same function, there is another dev_warn() for SCSI errors.

       /* Problem was not a check condition
         * Pass it up to the upper layers...
         */
        if (ei->ScsiStatus) {
            dev_warn(&h->pdev->dev, "cp %p has status 0x%x "
                "Sense: 0x%x, ASC: 0x%x, ASCQ: 0x%x, "


I am wondering whether it make sense to make the same change here as well as. This will suppress logging for other SCSI status, for example BUSY, TASK SET FULL, etc.

Sunny 

èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—