Re: [PATCH] regulator: Provide a check for dummy regulator

From: Mark Brown
Date: Fri Apr 20 2012 - 18:05:13 EST

On Sat, Apr 21, 2012 at 12:41:18AM +0530, Jassi Brar wrote:
> On 21 April 2012 00:18, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> > In any case, the solution is very clear - just do proper regulator
> > support and turn off dummy regulators and everything is fine.

> You earlier said there are always going to be 'new' platforms that would
> need dummy enabled.

When I say "need" I mean either "are at the point where just booting is
massive success so who cares if there's the odd bit of breakage" or
"have been randomly broken and need investigation as to what went

> Now just imagine if one of those platforms happen to share the consumer
> due to which you suggest disabling the dummy (omap_hsmmc in this case).
> If we re-enable dummy, then your's isn't really a solution.
> If we require that platform to come with full compliance, why can't we
> ask every platform to do the same?

We do ask every platform to do the same, but enough people run into
problems that it's been useful to provide a standard crutch people can
pick up to get their systems up and running. The theory is that dummy
regulators are enabled to help keep things running and as a debugging
aid, they're not intended for ongoing use. If nothing else the log
message that gets printed out whenever a dummy regulator is used can be
helpful in identifying what's missing from the board setup.

Attachment: signature.asc
Description: Digital signature